Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] pir dy2st unittest verification - Part 13 #59517

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Nov 29, 2023

PR types

Others

PR changes

Others

Description

状态 单测 错误类别 备注 报错信息
test_spec_names
test_convert_call_generator
test_slice: {TestSetValueWithLayerAndSave, TestSetValue} API 暂不支持OpResult.__setitem__
🟡 test_slice: {TestSliceInIf, TestSliceInWhileLoop, TestSliceInForLoop} 控制流 暂不支持控制流
test_full_name_usage 动转静执行 段错误,好像还是剪掉的问题?代码不好改写,可以考虑之后利用 FLAGS_enable_pir_api=true 切一下 Destoryed a op_result that is still in use.
test_tsm API 需要适配paddle.base.libpaddle.pir.Program._lr_schedule_guard,报错api是paddle.optimizer.Optimizer._create_param_lrparam_lr > 1.0部分,依赖 #59597
test_tsm 反向 CUDA 700,网络含 BN

相关链接:

Copy link

paddle-bot bot commented Dec 1, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

Comment on lines +792 to +804
if not use_pir_api():
with paddle.static.default_main_program()._lr_schedule_guard(
is_with_opt=True
), framework.name_scope(
'scale_with_param_lr'
):
return self._global_learning_rate() * param_lr
else:
# TODO(dev): Currently there has not equivalent of op_role in PIR
# mode, so we simply remove _lr_schedule_guard here, this should
# be fixed in the future.
with framework.name_scope('scale_with_param_lr'):
return self._global_learning_rate() * param_lr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按理说放在 Program._lr_schedule_guard,但现在 Python 端没相关的 patch,暂时直接这样写了

@SigureMo SigureMo merged commit d514d69 into PaddlePaddle:develop Dec 5, 2023
29 checks passed
@gouzil gouzil deleted the dy2st_pir_api_push_13 branch December 27, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants