Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon] Fix NO19,20 API Label #58827

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

Kaedeharai
Copy link
Contributor

PR types

Others

PR changes

Docs

Description

20那个是真看不懂,找不到api_name
照着19一样的改了一下
不知道怎么改了,麻烦大佬们帮忙看下吧

@paddle-bot paddle-bot bot added the contributor External developers label Nov 8, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 9, 2023
@Kaedeharai
Copy link
Contributor Author

@sunzhongkai588麻烦孙师傅看下

Copy link
Contributor

@ooooo-create ooooo-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work~ @sunzhongkai588

@@ -471,7 +471,7 @@ def load_inference_model_distributed(
"""
Load the inference model from a given directory. By this API, you can get the model
structure(Inference Program) and model parameters. If you just want to load
parameters of the pre-trained model, please use the :ref:`api_base_io_load_params` API.
parameters of the pre-trained model, please use the :ref:`api_paddle_base_io_load_params` API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api_base_io_load_params#50842 已经被删掉了,可以把 if 整句话都删了~

@@ -359,7 +359,7 @@ def data_reader():

def firstn(reader, n):
"""
paddle.base.io.firstn ( :ref:`api_base_io_firstn` ) is recommended to use,
paddle.base.io.firstn ( :ref:`api_paddle_base_io_firstn` ) is recommended to use,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一段是说明了别称的问题,但是这个 api 现在并没有公开暴露出来,可以整段都删了叭~

Copy link
Contributor

@ooooo-create ooooo-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit ac76d85 into PaddlePaddle:develop Nov 10, 2023
Copy link

paddle-bot bot commented Nov 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* [Docathon] Fix NO19,20 API Label

* modified:   python/paddle/distributed/io.py
	modified:   python/paddle/reader/decorator.py
@Kaedeharai Kaedeharai deleted the my-cool-stuff branch November 22, 2023 06:37
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* [Docathon] Fix NO19,20 API Label

* modified:   python/paddle/distributed/io.py
	modified:   python/paddle/reader/decorator.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants