Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docathon] Fix NO.13-NO.18 API label #57658

Merged
merged 11 commits into from
Oct 9, 2023
Merged

[Docathon] Fix NO.13-NO.18 API label #57658

merged 11 commits into from
Oct 9, 2023

Conversation

zade23
Copy link
Contributor

@zade23 zade23 commented Sep 22, 2023 •
edited
Loading

PR types

Others

PR changes

Docs

Description

#57363

序号 Origin label name Fixed label name
13 api_base_default_main_program api_static_default_main_program
14 api_base_default_startup_program api_static_default_startup_program
15 api_base_dygraph_disable_dygraph api_paddle_enable_static
16 api_base_dygraph_enable_dygraph api_paddle_disable_static
17 api_base_dygraph_guard api_paddle_guard
18 api_base_dygraph_to_variable api_paddle_to_tensor

@paddle-bot
Copy link

paddle-bot bot commented Sep 22, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 22, 2023
@zade23 zade23 mentioned this pull request Sep 22, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 25, 2023
ooooo-create
ooooo-create reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@ooooo-create ooooo-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

忘记加上paddle啦~

python/paddle/optimizer/optimizer.py Outdated Show resolved Hide resolved
python/paddle/optimizer/optimizer.py Outdated Show resolved Hide resolved
python/paddle/nn/clip.py Outdated Show resolved Hide resolved
python/paddle/incubate/optimizer/modelaverage.py Outdated Show resolved Hide resolved
python/paddle/incubate/optimizer/lookahead.py Outdated Show resolved Hide resolved
python/paddle/distributed/fleet/fleet.py Outdated Show resolved Hide resolved
python/paddle/base/dygraph/base.py Outdated
You can enter dynamic graph mode with :ref:`api_base_dygraph_guard` api,
or enable and disable dynamic graph mode with :ref:`api_base_dygraph_enable_dygraph`
and :ref:`api_base_dygraph_disable_dygraph` api .
You can enter dynamic graph mode with :ref:`api_paddle_guard` api,
Copy link
Contributor

@ooooo-create ooooo-create Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunzhongkai588 因为2.0默认是动态图模式，所以把 <You can enter dynamic graph mode with :ref:api_base_dygraph_guard api,> 删了，修改成 <You can enable and disable dynamic graph mode with :ref:api_base_dygraph_enable_dygraph ...> ,孙师傅看看怎么样~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得 ok 的， @SigureMo 看一下

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle.base.dygrapph.enable_dygraph 不是暴露的 API 吧？应该引用不了吧

  • enable_dygraph == disable_static
  • disable_dygraph == enable_static

可以用 paddle.enable_static 和 paddle.disable_static 这两个 API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，我引用了修改之前的文字内容😂，已经修改过了

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zade23 可以修改下，enter dynamic graph mode with :ref:api_paddle_guard api,删了变成 you can enable and disable dynamic graph mode with :ref:api_paddle_disable_static
and :ref:api_paddle_enable_static api .

Copy link
Contributor Author

@zade23 zade23 Sep 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zade23 可以修改下，enter dynamic graph mode with :ref:api_paddle_guard api,删了变成 you can enable and disable dynamic graph mode with :ref:api_paddle_disable_static and :ref:api_paddle_enable_static api .

@ooooo-create
了解了，如果保持意思不变，改成如下这样会不会更通顺一点呢🤔

You can enable dynamic graph mode with :ref:`api_paddle_disable_static` api, 
or disable dynamic graph mode with :ref:`api_paddle_enable_static` .

sunzhongkai588
sunzhongkai588 previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 6, 2023

Sorry to inform you that 2a7328f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@luotao1 luotao1 merged commit 74e7a6c into PaddlePaddle:develop Oct 9, 2023
@zade23 zade23 deleted the 13_18 branch October 9, 2023 08:58
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
@zade23 @ooooo-create @Frida-a
[Docathon] Fix NO.13-NO.18 API label (PaddlePaddle#57658)
53dbce2 
* fix 13_18

* Update python/paddle/optimizer/optimizer.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/optimizer/optimizer.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/nn/clip.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/incubate/optimizer/modelaverage.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/incubate/optimizer/lookahead.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/distributed/fleet/fleet.py

Co-authored-by: ooo oo <[email protected]>

* Update base.py

fix ref_dygraph

---------

Co-authored-by: ooo oo <[email protected]>
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
@zade23 @ooooo-create @jiahy0825
[Docathon] Fix NO.13-NO.18 API label (PaddlePaddle#57658)
413d7c9 
* fix 13_18

* Update python/paddle/optimizer/optimizer.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/optimizer/optimizer.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/nn/clip.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/incubate/optimizer/modelaverage.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/incubate/optimizer/lookahead.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/distributed/fleet/fleet.py

Co-authored-by: ooo oo <[email protected]>

* Update base.py

fix ref_dygraph

---------

Co-authored-by: ooo oo <[email protected]>
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@zade23 @ooooo-create
[Docathon] Fix NO.13-NO.18 API label (PaddlePaddle#57658)
6b33333 
* fix 13_18

* Update python/paddle/optimizer/optimizer.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/optimizer/optimizer.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/nn/clip.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/incubate/optimizer/modelaverage.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/incubate/optimizer/lookahead.py

Co-authored-by: ooo oo <[email protected]>

* Update python/paddle/distributed/fleet/fleet.py

Co-authored-by: ooo oo <[email protected]>

* Update base.py

fix ref_dygraph

---------

Co-authored-by: ooo oo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo left review comments

@ooooo-create ooooo-create ooooo-create left review comments

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees

@luotao1 luotao1

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zade23 @SigureMo @sunzhongkai588 @ooooo-create @luotao1