Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xdoctest][task 291] reformat example code with google style in python/paddle/incubate/operators/unzip.py #56826

Merged
merged 4 commits into from
Sep 1, 2023
Merged

[xdoctest][task 291] reformat example code with google style in python/paddle/incubate/operators/unzip.py #56826

merged 4 commits into from
Sep 1, 2023

Conversation

jinyouzhi
Copy link
Contributor

@paddle-bot
Copy link

paddle-bot bot commented Aug 30, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 30, 2023
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Aug 31, 2023
@jinyouzhi jinyouzhi requested review from megemini and SigureMo August 31, 2023 13:58
SigureMo

This comment was marked as duplicate.

Sign in to view

SigureMo
SigureMo approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

不过这个 log 是不是还是被吞了 @megemini，这个 PR 是昨天提的

image

@luotao1 luotao1 merged commit aa28e44 into PaddlePaddle:develop Sep 1, 2023
@luotao1 luotao1 mentioned this pull request Sep 1, 2023
Closed
@luotao1
Copy link
Contributor

luotao1 commented Sep 1, 2023

@yuchen202 291已经合入了，请不要做重了

@megemini
Copy link
Contributor

megemini commented Sep 1, 2023

不过这个 log 是不是还是被吞了 @megemini，这个 PR 是昨天提的

没有被吞 ～

    if len(docstrings_to_test) == 0 and len(whl_error) == 0:
        logger.info("-----API_PR.spec is the same as API_DEV.spec-----")
        sys.exit(0)

这里直接退出了 ～

不过，这样确实不太好，应该最后有 End of the check 之类的 ～ 我改一下吧 ～

@SigureMo
Copy link
Member

SigureMo commented Sep 1, 2023

不过，这样确实不太好，应该最后有 End of the check 之类的 ～ 我改一下吧 ～

嗯嗯～

@SigureMo SigureMo mentioned this pull request Sep 3, 2023
Merged
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@jinyouzhi @SigureMo @BeingGod
[xdoctest][task 291] reformat example code with google style in `pyth…
dd8db4e 
…on/paddle/incubate/operators/unzip.py` (PaddlePaddle#56826)

* [Doctest] fix No.291, test=docs_preview

* fix

* Update python/paddle/incubate/operators/unzip.py

* switch to gpu

---------

Co-authored-by: Nyakku Shigure <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

@megemini megemini Awaiting requested review from megemini

Assignees

@luotao1 luotao1

@SigureMo SigureMo

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jinyouzhi @luotao1 @megemini @SigureMo @sunzhongkai588