[xdoctest][task 318-322] reformat example code with google style in `paddle/fluid/*` and `python/paddle/sparse/unary` #56748

whisky-12 · 2023-08-29T03:42:11Z

PR types

Others

PR changes

Others

Description

修改如下文件的示例代码，使其通过 xdoctest 检查：

python/paddle/sparse/unary.py
paddle/fluid/operators/fused/fused_elemwise_activation_op.cc
paddle/fluid/pybind/cuda_streams_py.cc
paddle/fluid/pybind/custom_device_py.cc
paddle/fluid/pybind/inference_api.cc

预览：

Related links

@sunzhongkai588 @SigureMo @megemini

…udio/*

megemini · 2023-08-29T10:34:34Z

python/paddle/sparse/unary.py

+            >>> import paddle
+
+            >>> format = "coo"
+            >>> dense_x = paddle.randn((5, 5), dtype='float64')
+
+            >>> if format == "coo":
+            ...     sparse_x = dense_x.to_sparse_coo(len(dense_x.shape))
+            >>> else:
+            ...     sparse_x = dense_x.to_sparse_csr()
+
+            >>> print("sparse.pca_lowrank API only support CUDA 11.x")
+            >>> U, S, V = None, None, None
+            >>> # use code blow when your device CUDA version >= 11.0
+            >>> # U, S, V = paddle.sparse.pca_lowrank(sparse_x)
+
+            >>> print(U)


这段代码可以在 gpu 下面跑，试一下：

加个 REQUIRES 和 set_device

加个 seed，因为有 randn

使用 U, S, V = paddle.sparse.pca_lowrank(sparse_x) 而不是 U, S, V = None, None, None

然后看看结果如何～

收到辛苦review ，已更新代码

您好尊敬的 @megemini 先生：
本次对应将U, S, V = paddle.sparse.pca_lowrank(sparse_x) 结果值分别进行打印，根据log显示 CI check失败，报错信息如下：

根据目前情况是否执行 >>> # doctest: +SKIP('random sample') 跳过测试？

根据目前情况是否执行 >>> # doctest: +SKIP('random sample') 跳过测试？

先不要跳过～

这段示例代码的输出没有改，导致的错误～

从日志上看，我在 aistudio 上用 dev 版本的 gpu 环境，测试的结果跟 ci 结果是一样的～

自己尝试运行，然后修改一下示例中的结果吧。

…udio/*

megemini

我在 aistudio 用 dev 版本测试，pca_lowrank 是没问题的，包括随机结果也一致～

但是 CI 环境中运行出错了～

@SigureMo 看看咋整？ @whisky-12 抽空重新跑一下 CI 试试？

SigureMo · 2023-09-05T06:07:38Z

@SigureMo 看看咋整？ @whisky-12 抽空重新跑一下 CI 试试？

我 rerun 下试试

whisky-12 · 2023-09-05T06:41:55Z

我在 aistudio 用 dev 版本测试，pca_lowrank 是没问题的，包括随机结果也一致～

但是 CI 环境中运行出错了～

@SigureMo 看看咋整？ @whisky-12 抽空重新跑一下 CI 试试？

@SigureMo 看看咋整？ @whisky-12 抽空重新跑一下 CI 试试？

我 rerun 下试试

收到，辛苦了，我在aistudio也跑了下结果如下：

目前情况是昨天晚上和今天早上相同的代码今天是第二次执行CI

megemini · 2023-09-05T10:26:16Z

收到，辛苦了，我在aistudio也跑了下结果如下：

图挂了～ 🫠🫠🫠 你能看到？

whisky-12 · 2023-09-06T01:24:02Z

收到，辛苦了，我在aistudio也跑了下结果如下：

图挂了～ 🫠🫠🫠 你能看到？

哎嘿，我这边页面图片正常显示呀，容我再传一张：

详细结果见上图，辛苦了

megemini · 2023-09-06T07:07:32Z

github 抽风了，现在我这边头像也看不到了～ 🤣🤣🤣

搞不明白了，只能怀疑 ci 里面的包有问题？

whisky-12 · 2023-09-06T08:11:33Z

github 抽风了，现在我这边头像也看不到了～ 🤣🤣🤣

搞不明白了，只能怀疑 ci 里面的包有问题？

🤣🤣🤣 其实我比较好奇同样的代码 CI的报错量咋还不一样了呢，难搞哦

SigureMo · 2023-09-06T18:37:09Z

paddle/fluid/pybind/cuda_streams_py.cc

这个文件里大量示例代码没有修改格式

之前已经合入的其他 PR 也有这个问题，review 时候不可能看每个文件是否全部改完，只能靠自觉

@megemini 有时间看看 .cc 文件目前是不支持嘛？

感谢对问题的指摘，辛苦了，之前由于对函数模块的理解错误，造成了遗漏，对此深表歉意，我这边会重新对代码进行排查，再次感谢，辛苦了

@megemini 有时间看看 .cc 文件目前是不支持嘛？

工具没有限制文件类型，这里是因为，cc 里面文档的书写方式与python不同(cc: DOC...DOC, python: """...""") ～

我把工具里面解析的正则改一下吧～

不过，这个应该不影响 CI 里面的检查，CI 里面是直接读取 docstring 的～

已更新，pull 试一下～

megemini

2023-09-08 10:37:57 --------------------------------------
2023-09-08 10:37:57 C++ Traceback (most recent call last):
2023-09-08 10:37:57 --------------------------------------
2023-09-08 10:37:57 0   phi::DenseTensor::~DenseTensor()
2023-09-08 10:37:57 1   std::_Sp_counted_deleter<phi::Allocation*, std::function<void (phi::Allocation*)>, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose()
2023-09-08 10:37:57 2   paddle::memory::allocation::StatAllocator::FreeImpl(phi::Allocation*)
2023-09-08 10:37:57 3   paddle::memory::allocation::CPUAllocator::FreeImpl(phi::Allocation*)

日志里面 paddle.sparse.transpose 挂了～这是啥意思？回收内存的时候挂了？

megemini · 2023-09-08T04:54:25Z

python/paddle/sparse/unary.py

+            >>> out1 = paddle.sparse.sum(sparse_x)  # [1.]
+            >>> out2 = paddle.sparse.sum(sparse_x, axis=0)  # [-1., 2.]
+            >>> out3 = paddle.sparse.sum(sparse_x, axis=-1)  # [-2., 3.]
+            >>> out4 = paddle.sparse.sum(sparse_x, axis=1, keepdim=True)  # [[-2.], [3.]]


这里可以用print把输出打印出来～

megemini · 2023-09-10T04:16:51Z

2023-09-10 04:37:32 DOCTEST DEBUG INFO
2023-09-10 04:37:32   XDoc "<modpath?>::paddle.sparse.transpose:1:0", line 7 <- wrt doctest
2023-09-10 04:37:32   File "<fpath?>", line 7, <- wrt source file
2023-09-10 04:37:32 DOCTEST PART BREAKDOWN
2023-09-10 04:37:32 Passed Parts:
2023-09-10 04:37:32     1 >>> import paddle
2023-09-10 04:37:32     3 >>> dense_x = paddle.to_tensor([[-2., 0.], [1., 2.]])
2023-09-10 04:37:32     4 >>> sparse_x = dense_x.to_sparse_coo(1)
2023-09-10 04:37:32     5 >>> out = paddle.sparse.transpose(sparse_x, [1, 0])
2023-09-10 04:37:32 Failed Part:
2023-09-10 04:37:32     6 >>> out
2023-09-10 04:37:32 DOCTEST TRACEBACK
2023-09-10 04:37:32 Differences (unified diff with -expected +actual):
2023-09-10 04:37:32     @@ -1,4 +1,4 @@
2023-09-10 04:37:32      Tensor(shape=[2, 2], dtype=paddle.float32, place=Place(cpu), stop_gradient=True,
2023-09-10 04:37:32     -    indices=[[0, 0]],
2023-09-10 04:37:32     -    values=[[-2.,  0.],
2023-09-10 04:37:32     -            [ 1.,  2.]])
2023-09-10 04:37:32     +       indices=[[1139, 65  ]],
2023-09-10 04:37:32     +       values=[[-2.,  0.],
2023-09-10 04:37:32     +               [ 1.,  2.]])
2023-09-10 04:37:32     
2023-09-10 04:37:32 Repr Difference:
2023-09-10 04:37:32     got  = 'Tensor(shape=[2, 2], dtype=paddle.float32, place=Place(cpu), stop_gradient=True, \n       indices=[[1139, 65  ]], \n       values=[[-2.,  0.],\n               [ 1.,  2.]])'
2023-09-10 04:37:32     want = 'Tensor(shape=[2, 2], dtype=paddle.float32, place=Place(cpu), stop_gradient=True,\n    indices=[[0, 0]],\n    values=[[-2.,  0.],\n            [ 1.,  2.]])'
2023-09-10 04:37:32 DOCTEST REPRODUCTION
2023-09-10 04:37:32 CommandLine:
2023-09-10 04:37:32     python -m xdoctest <modpath?> paddle.sparse.transpose:1:0

在 aistudio 上面运行，会卡死～还是有点问题 ... ...

In [1]: import paddle
pa
In [2]: paddle.set_device('cpu')
Out[2]: Place(cpu)

In [3]: 

In [3]:             >>> import paddle
   ...:             >>> dense_x = paddle.to_tensor([[-2., 0.], [1., 2.]])
   ...:             >>> sparse_x = dense_x.to_sparse_coo(1)
   ...:             >>> out = paddle.sparse.transpose(sparse_x, [1, 0])
   ...:             >>> out
malloc_consolidate(): invalid chunk size

SigureMo

LGTMeow 🐾

SigureMo · 2023-09-10T07:04:58Z

python/paddle/sparse/unary.py

+            Tensor(shape=[2, 2], dtype=paddle.float32, place=Place(cpu), stop_gradient=True,
+                indices=[[0, 0]],
+                values=[[-2.,  0.],
+                        [ 1.,  2.]])


2023-09-08 10:37:57 -------------------------------------- 2023-09-08 10:37:57 C++ Traceback (most recent call last): 2023-09-08 10:37:57 -------------------------------------- 2023-09-08 10:37:57 0 phi::DenseTensor::~DenseTensor() 2023-09-08 10:37:57 1 std::_Sp_counted_deleter<phi::Allocation*, std::function<void (phi::Allocation*)>, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() 2023-09-08 10:37:57 2 paddle::memory::allocation::StatAllocator::FreeImpl(phi::Allocation*) 2023-09-08 10:37:57 3 paddle::memory::allocation::CPUAllocator::FreeImpl(phi::Allocation*)

日志里面 paddle.sparse.transpose 挂了～这是啥意思？回收内存的时候挂了？

这个问题有时间 @zrr1999 看一下吧 [doge]，这个 PR 我觉得可以先行合入

SigureMo

LGTMeow 🐾

whisky-12 and others added 2 commits August 29, 2023 11:39

[xdoctest][task 318-322] reformat example code with google style in a…

5d2d3df

…udio/*

Merge branch 'PaddlePaddle:develop' into xdoctest-318-322

c574cd2

megemini reviewed Aug 29, 2023

View reviewed changes

paddle-bot bot added the contributor External developers label Aug 29, 2023

luotao1 assigned luotao1, SigureMo and sunzhongkai588 Aug 31, 2023

luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Aug 31, 2023

Merge branch 'PaddlePaddle:develop' into xdoctest-318-322

ad67c26

whisky-12 changed the title ~~[xdoctest][task 318-322] reformat example code with google style in a…~~ [xdoctest][task 318-322] reformat example code with google style in audio/* Aug 31, 2023

whisky-12 and others added 4 commits August 31, 2023 15:53

[xdoctest][task 318-322] reformat example code with google style in a…

623838d

…udio/*

Merge branch 'PaddlePaddle:develop' into xdoctest-318-322

9cb488d

[xdoctest][task 318-322] reformat example code with google style in a…

fc70a3e

…udio/*

Merge branch 'PaddlePaddle:develop' into xdoctest-318-322

b1287cf

megemini reviewed Sep 5, 2023

View reviewed changes

Merge branch 'PaddlePaddle:develop' into xdoctest-318-322

47a2f32

SigureMo reviewed Sep 6, 2023

View reviewed changes

whisky-12 and others added 4 commits September 7, 2023 09:48

Merge branch 'PaddlePaddle:develop' into xdoctest-318-322

a2e8b9e

convert missing cases

5def0e2

fix an indent

1ee78ee

fix wrong >>> in cpp code

a988c10

megemini reviewed Sep 8, 2023

View reviewed changes

SigureMo added 2 commits September 10, 2023 00:52

Merge branch 'develop' into xdoctest-318-322

ebf9b1c

guard outputs

74123f6

SigureMo added 2 commits September 10, 2023 01:12

guard more outputs

0f181bb

try to fix mem free

79d6bb4

SigureMo changed the title [xdoctest][task 318-322] reformat example code with google style in audio/* [xdoctest][task 318-322] reformat example code with google style in paddle/fluid/* and python/paddle/sparse/unary Sep 9, 2023

try to fix mem free

c94be2c

revert changes in paddle/phi/kernels/sparse/cpu/transpose_kernel.cc

a9aa63f

SigureMo previously approved these changes Sep 10, 2023

View reviewed changes

zrr1999 added 2 commits September 10, 2023 08:08

fix bug

6e089e6

fix bug

f054810

zrr1999 dismissed SigureMo’s stale review via f054810 September 10, 2023 08:37

SigureMo added 2 commits September 10, 2023 17:07

fix codestyle

e4c195a

revert changes in paddle/phi/kernels/sparse/cpu/transpose_kernel.cc

3d41e3a

SigureMo approved these changes Sep 10, 2023

View reviewed changes

luotao1 merged commit 66d7442 into PaddlePaddle:develop Sep 11, 2023

luotao1 mentioned this pull request Sep 11, 2023

[xdoctest] 分批次修改已有代码的示例 #55629

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[xdoctest][task 318-322] reformat example code with google style in `paddle/fluid/*` and `python/paddle/sparse/unary` #56748

[xdoctest][task 318-322] reformat example code with google style in `paddle/fluid/*` and `python/paddle/sparse/unary` #56748

whisky-12 commented Aug 29, 2023

megemini Aug 29, 2023

whisky-12 Aug 31, 2023

whisky-12 Sep 1, 2023

megemini Sep 1, 2023 •

edited

Loading

megemini left a comment

SigureMo commented Sep 5, 2023

whisky-12 commented Sep 5, 2023

megemini commented Sep 5, 2023

whisky-12 commented Sep 6, 2023

megemini commented Sep 6, 2023

whisky-12 commented Sep 6, 2023

SigureMo Sep 6, 2023 •

edited

Loading

whisky-12 Sep 7, 2023

megemini Sep 7, 2023

megemini Sep 7, 2023

megemini left a comment

megemini Sep 8, 2023

megemini commented Sep 10, 2023

SigureMo left a comment

SigureMo Sep 10, 2023

SigureMo left a comment

[xdoctest][task 318-322] reformat example code with google style in paddle/fluid/* and python/paddle/sparse/unary #56748

[xdoctest][task 318-322] reformat example code with google style in paddle/fluid/* and python/paddle/sparse/unary #56748

Conversation

whisky-12 commented Aug 29, 2023

PR types

PR changes

Description

Related links

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

megemini Sep 1, 2023 • edited Loading

Choose a reason for hiding this comment

megemini left a comment

Choose a reason for hiding this comment

SigureMo commented Sep 5, 2023

whisky-12 commented Sep 5, 2023

megemini commented Sep 5, 2023

whisky-12 commented Sep 6, 2023

megemini commented Sep 6, 2023

whisky-12 commented Sep 6, 2023

SigureMo Sep 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

megemini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

megemini commented Sep 10, 2023

SigureMo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SigureMo left a comment

Choose a reason for hiding this comment

[xdoctest][task 318-322] reformat example code with google style in `paddle/fluid/*` and `python/paddle/sparse/unary` #56748

[xdoctest][task 318-322] reformat example code with google style in `paddle/fluid/*` and `python/paddle/sparse/unary` #56748

megemini Sep 1, 2023 •

edited

Loading

SigureMo Sep 6, 2023 •

edited

Loading