[xdoctest] reformat example code with google style in No. 203 - 211 #56473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@SigureMo 发起Review申请🐕 |
megemini
reviewed
Aug 21, 2023
Comment on lines
172
to
173
| [[[1, 2, 3], [4, 5, 6]], [[13, 14, 15], [16, 17, 18]]] (2 GPUs, out for rank 0) | ||
| [[[7, 8, 9], [10, 11, 12]], [[19, 20, 21], [22, 23, 24]]] (2 GPUs, out for rank 1) |
There was a problem hiding this comment.
(2 GPUs, out for rank 0) 不应该出现在 print 里面吧 ～ 可以放到上面语句里面作为注释。
Comment on lines
309
to
310
| [0, 2] (2 GPUs, out for rank 0) | ||
| [1, 3] (2 GPUs, out for rank 1) |
Comment on lines
329
to
330
| [[0., 0.], [1., 1.]] (2 GPUs, out for rank 0) | ||
| [[0., 0.], [0., 0.], [1., 1.], [1., 1.]] (2 GPUs, out for rank 1) |
| >>> task.wait() | ||
| >>> out = data.numpy() | ||
| >>> print(out) | ||
| [[1, 2, 3], [1, 2, 3]] (2 GPUs) |
Liyulingyue
commented
Aug 21, 2023
python/paddle/distributed/communication/stream/reduce_scatter.py
Outdated
Show resolved
Hide resolved
python/paddle/distributed/communication/stream/reduce_scatter.py
Outdated
Show resolved
Hide resolved
|
请 @megemini 再review一下 |
megemini
approved these changes
Aug 23, 2023
luotao1
approved these changes
Aug 23, 2023
luotao1
approved these changes
Aug 23, 2023
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
…addlePaddle#56473) * 203 * 204 * 205 * 206 * 207 * 208 * 209 * 210 * 211 * Update all_to_all.py * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
#55629