Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine interface of hlir::framework::Instruction #56123

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

Candy2Tang
Copy link
Contributor

@Candy2Tang Candy2Tang commented Aug 9, 2023

PR types

Function optimization

PR changes

Others

Description

  • DumpInstruction 函数没有修改成员变量,应该用 const 修饰
  • GetInArgsGetOutArgs等三个函数有两处可以优化:①用 const 修饰 ② 返回引用,避免copy

@paddle-bot
Copy link

paddle-bot bot commented Aug 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 9, 2023
@Candy2Tang
Copy link
Contributor Author

@Ligoml 你好,我是从 #45347 热身打卡这里进来的,最近在学习CINN 框架的代码,看到有部分接口代码可以优化,故提了一个PR,想问下找谁review呢?

@luotao1 luotao1 merged commit dbd9743 into PaddlePaddle:develop Aug 10, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 10, 2023

hi, @Candy2Tang

  • 非常感谢你对飞桨框架的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 [email protected],我们会邀请你加入~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants