[IR Operation] ⚔Elden chapter 1.3⚔ #55657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouzil
commented
Jul 24, 2023
| @@ -214,6 +214,10 @@ Region *Operation::GetParentRegion() const { | |||
| return parent_ ? parent_->GetParent() : nullptr; | |||
| } | |||
|
|
|||
| Region *Operation::GetParentRegion() { | |||
There was a problem hiding this comment.
这个我们内部之前讨论了下，其实这里的接口按照规范要分为两个：
const X* GetX() const;
X* GetX();
即 const 对象接口应该返回const对象，非const接口返回非const对象。
但似乎这里存量代码本身也存在类似的问题。
There was a problem hiding this comment.
这里比较高频的接口是 GetParentProgram、GetParent，可以把这两个接口规范下即可。
gouzil
changed the title
Aurelius84
reviewed
Jul 27, 2023
paddle/ir/core/operation.cc
Outdated
| @@ -227,6 +227,15 @@ Program *Operation::GetParentProgram() { | |||
| return module_op ? module_op.program() : nullptr; | |||
There was a problem hiding this comment.
非const可以调用const的实现，可能需要对返回做一次const_cast，这样就只需要维护一份代码就可以了
Aurelius84
approved these changes
Aug 1, 2023
sunzhongkai588
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
#55205 case 1.3