Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang Compile #5217

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Fix clang Compile #5217

merged 1 commit into from
Oct 30, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 30, 2017 •
edited
Loading

clang will warning the previous code and fail to compile.

@reyoung reyoung requested a review from QiJune October 30, 2017 18:14
@reyoung reyoung changed the title Fix MacOS Compile Fix clang Compile Oct 30, 2017
QiJune
QiJune approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QiJune QiJune merged commit 2b1f21a into PaddlePaddle:develop Oct 30, 2017
@reyoung reyoung deleted the feature/fill_compile branch December 26, 2017 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @QiJune