No.54：为 Paddle allclose、isclose 算子实现 float16 数据类型支持 #51168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
辛苦分别为2个算子补充FP16的OpTest，用来验证精度。 具体写法可以参考低精度单测添加介绍中的step2：https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/amp_precision/amp_test_dev_guide_cn.html#step2 也可以参考这个#50952 |
Vvsmile
reviewed
Mar 9, 2023
| phi::AllCloseKernel, | ||
| float, | ||
| double, | ||
| phi::dtype::float16) { |
Vvsmile
reviewed
Mar 9, 2023
| phi::IscloseKernel, | ||
| float, | ||
| double, | ||
| phi::dtype::float16) {} |
There was a problem hiding this comment.
在这个题目中暂时不添加bf16的支持。我们会有另外的题目
Vvsmile
reviewed
Mar 9, 2023
| @@ -170,6 +171,36 @@ def test_equal_nan(): | |||
| self.assertRaises(TypeError, test_equal_nan) | |||
|
|
|||
|
|
|||
| class TestAllcloseOpFp16(unittest.TestCase): | |||
There was a problem hiding this comment.
已经添加了继承OpTest的单测，这个单测是测的静态图分支
Vvsmile
reviewed
Mar 9, 2023
| @@ -203,6 +204,36 @@ def test_equal_nan(): | |||
| self.assertRaises(TypeError, test_equal_nan) | |||
|
|
|||
|
|
|||
| class TestIscloseOpFp16(unittest.TestCase): | |||
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
任务链接：#50658 (comment)
中文文档修复链接：PaddlePaddle/docs#5688