Add unsigned int8 scale propagation #46378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
This was referenced Sep 21, 2022
yeliang2258
reviewed
Sep 22, 2022
yeliang2258
reviewed
Sep 22, 2022
zuzg
previously approved these changes
Sep 28, 2022
sfraczek
reviewed
Sep 28, 2022
paddle/fluid/framework/ir/mkldnn/compute_propagate_scales_mkldnn_pass.cc
Outdated
Show resolved
Hide resolved
| for (auto& var_name : variable_names) { | ||
| auto iter = var_quant_scales->find(var_name); | ||
| ASSERT_NE(iter, var_quant_scales->end()); | ||
| ASSERT_EQ((*var_quant_scales)[var_name].first, true); |
There was a problem hiding this comment.
You could perhaps reuse iter here but it's okay.
paddle/fluid/framework/ir/mkldnn/cpu_quantize_squash_pass_tester.cc
Outdated
Show resolved
Hide resolved
paddle/fluid/framework/ir/mkldnn/cpu_quantize_squash_pass_tester.cc
Outdated
Show resolved
Hide resolved
wozna
force-pushed
the
concat_acc_fix
branch
from
6b4356d
to
dac2f6f
Compare
wozna
force-pushed
the
concat_acc_fix
branch
2 times, most recently
from
c2c736a
to
f8fd057
Compare
yeliang2258
requested review from
sfraczek and
zuzg
and removed request for
zuzg
|
@wozna Hello, does this PR still need to be updated? do you need us to merge |
@yeliang2258 It is ready to be merged. |
jiangjiajun
approved these changes
Oct 13, 2022
ZeyuChen
pushed a commit
that referenced
this pull request
Oct 19, 2022
* Add unsigned int8 propagation * Add or modify unit tests * Correct concat scale checking * Apply review suggestions * Corrections Co-authored-by: joanna.wozna.intel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
I found out that in cpu_quantize_squash_pass there was check to prevent squashing dequantize and quantize with different data type (int8/uint8) but it was not working correctly. In
compute_propagate_scales_mkldnn_passwe have scale propagation so eg. scale before reshape2 is applied after reshape var but the type (uint8 or int8) weren't applied.This PR fixes picodet int8 acc drop #44075 and fixes concat error in #45970