Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI] Migrate cast, clip+grad and pool+grad oneDNN kernels #45775

Merged
merged 18 commits into from
Sep 8, 2022
Merged

[PHI] Migrate cast, clip+grad and pool+grad oneDNN kernels #45775

merged 18 commits into from
Sep 8, 2022

Conversation

piotrekobi
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Migrates the following oneDNN operator kernels to PHI:

  • cast
  • clip
  • clip_grad
  • pool2d
  • pool2d_grad

@paddle-bot
Copy link

paddle-bot bot commented Sep 5, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Sep 5, 2022
@piotrekobi
Copy link
Contributor Author

@chenwhql @jczaja Please review.
Again, Coverage CI is claiming that some code is not tested, but there are Python tests that test the kernels.

chenwhql
chenwhql reviewed Sep 7, 2022
View reviewed changes
paddle/phi/kernels/onednn/cast_kernel.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/onednn/cast_kernel.cc Show resolved Hide resolved
paddle/phi/kernels/onednn/clip_kernel.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/onednn/pool_grad_kernel.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/onednn/pool_kernel.cc Outdated Show resolved Hide resolved
@Silv3S Silv3S added the Intel label Sep 7, 2022
@Silv3S Silv3S mentioned this pull request Sep 7, 2022
Closed
@chenwhql chenwhql merged commit 1a929c3 into PaddlePaddle:develop Sep 8, 2022
@piotrekobi piotrekobi mentioned this pull request Sep 12, 2022
Closed
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrekobi @chenwhql @Silv3S