Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI] Migrate relu6 and abs kernels #45397

Merged
merged 13 commits into from
Aug 29, 2022

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Aug 24, 2022

PR types

Others

PR changes

Others

Describe

  • migrate 2 OneDNN kernels to PHI (relu6 and abs)
  • change MKLDNN naming to OneDNN.

@paddle-bot
Copy link

paddle-bot bot commented Aug 24, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 24, 2022
@Silv3S Silv3S changed the title [PHI] Migrate relu6, abs, gaussian_random and scale kernels [PHI] Migrate relu6 and abs kernels Aug 26, 2022
@Silv3S
Copy link
Member Author

Silv3S commented Aug 26, 2022

Hi @chenwhql, could you please review?

Along with migration, we would like to standardize the nomenclature. There are currently two names in use, one of which is obsolete (MKLDNN). As the migration progresses, we will overwrite MKLDNN with OneDNN.

@Silv3S Silv3S requested a review from chenwhql August 26, 2022 10:24
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 632bc1f into PaddlePaddle:develop Aug 29, 2022
@Silv3S Silv3S deleted the phi_migration_part_1 branch August 29, 2022 11:46
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants