[CodeStyle] use np.testing.assert_array_equal instead of self.assertTrue(np.array_equal(...)) #44947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
luotao1
added
the
PFCC
SigureMo
changed the title
SigureMo
force-pushed
the
unittest-improvement
branch
from
b8b4034
to
73be70a
Compare
|
很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。 |
这不是修复导致的错误，这些是原来 `self.assertTrue(..., True)` 的错误用法，因此在修复后将其认为位置参数 `err_msg`
SigureMo
changed the title
SigureMo
commented
Aug 8, 2022
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
There was a problem hiding this comment.
这个文件看起来全是 change 是因为原来文件是 CRLF 换行的
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
使用
np.testing.assert_array_equal(...)替换self.assertTrue(np.array_equal(...))，以优化单测报错信息Changes
self.assertTrue(np.array_equal(...))->np.testing.assert_array_equal(...)self.assertEqual(np.array_equal(...), True)->np.testing.assert_array_equal(...)self.assertTrue(numpy.array_equal(...))->np.testing.assert_array_equal(...)self.assertTrue(np.array_equal(...), True)移除True