Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] use np.testing.assert_allclose instead of assertTrue(np.allclose(...)), test=kunlun #44799

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

ronny1996
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

use np.testing.assert_allclose instead of assertTrue(np.allclose(...))
#44641

@paddle-bot
Copy link

paddle-bot bot commented Aug 2, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

qili93
qili93 previously approved these changes Aug 4, 2022
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaociZhang XiaociZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_assign_value_op_xpu.py,test_matmul_op_xpu.py,test_fleet_exe_dist_model_run_xpu.py这几个麻烦也一起改掉吧

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaociZhang XiaociZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qili93 qili93 merged commit 230f3da into PaddlePaddle:develop Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants