Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add int8 scale calculation and conv weights quantization pass to paddle_pass_builder #44680

Merged
merged 2 commits into from
Sep 2, 2022
Merged

add int8 scale calculation and conv weights quantization pass to paddle_pass_builder #44680

merged 2 commits into from
Sep 2, 2022

Conversation

sfraczek
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

int8 scale calculation and params quantization can be enabled for mkldnn int8 c++ path (no save_quant_model.py).

@sfraczek sfraczek requested a review from wozna July 27, 2022 14:50
wozna
wozna previously approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-intel lidanqing-intel self-requested a review July 27, 2022 16:49
lidanqing-intel
lidanqing-intel previously approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Sep 1, 2022
@sfraczek sfraczek dismissed stale reviews from lidanqing-intel and wozna via bc67924 September 1, 2022 12:41
@sfraczek sfraczek changed the title [draft] add int8 scale calculation and conv weights quantization pass to paddle_pass_builder add int8 scale calculation and conv weights quantization pass to paddle_pass_builder Sep 1, 2022
@sfraczek sfraczek requested a review from wozna September 1, 2022 12:43
@sfraczek sfraczek requested a review from jczaja September 2, 2022 11:49
jczaja
jczaja approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit cdb36da into PaddlePaddle:develop Sep 2, 2022
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczaja jczaja jczaja approved these changes

@lidanqing-intel lidanqing-intel lidanqing-intel left review comments

@wozna wozna Awaiting requested review from wozna

Assignees
No one assigned
Labels
int8 Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfraczek @jczaja @wozna @lidanqing-intel