[JitLayer]Pybind JitLayer VarBase Function and add python UT #44010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurelius84
reviewed
Jul 4, 2022
Aurelius84
reviewed
Jul 7, 2022
paddle/fluid/jit/compilation_unit.cc
Outdated
| } | ||
|
|
||
| const FunctionMap &CompilationUnit::FunctionDict() const { | ||
| return function_dict_; |
There was a problem hiding this comment.
function_dict_ 不是一个合适的命名，因为dict是python的概念。C++里是map，下个PR可以考虑优化下
paddle/fluid/jit/compilation_unit.h
Outdated
| @@ -32,8 +34,12 @@ class CompilationUnit { | |||
| void SetFunction(const std::string &name, | |||
| const std::shared_ptr<BaseFunction> &function); | |||
|
|
|||
| std::vector<std::string> FunctionNames() const; | |||
|
|
|||
| const FunctionMap &FunctionDict() const; | |||
There was a problem hiding this comment.
同上，这里的FunctionDict也不是一个好的API名
paddle/fluid/pybind/pybind.cc
Outdated
| #include "paddle/phi/core/compat/convert_utils.h" | ||
| #include "paddle/phi/core/lod_utils.h" | ||
| #include "paddle/utils/none.h" | ||
| #ifdef PADDLE_WITH_ASCEND | ||
| #include "paddle/fluid/pybind/ascend_wrapper_py.h" | ||
| #endif | ||
| #include "paddle/fluid/jit/executor_function.h" | ||
| #include "paddle/fluid/jit/layer.h" | ||
| #include "paddle/fluid/jit/serializer.h" |
python/paddle/jit/layer.py
Outdated
| from paddle.fluid.core import Load | ||
|
|
||
|
|
||
| class Layer(): |
There was a problem hiding this comment.
Suggested change
| class Layer(): | |
| class Layer: | |
| 或者 | |
| class Layer(object) |
python/paddle/jit/layer.py
Outdated
| def __init__(self): | ||
| self.cpp_layer = None | ||
| # {name: Function} | ||
| self.funciton_map = {} |
There was a problem hiding this comment.
Suggested change
| self.funciton_map = {} | |
| self.functions = {} |
有单词拼写错误，另外这里的dict需要使用WeakRef么？
There was a problem hiding this comment.
这里应该不需要WeakRef吧，funciton_map 持有的python端的 Function: self.funciton_map[name] = Function(function)。其余的意见已经修改，感谢
python/paddle/jit/layer.py
Outdated
|
|
||
| for name, function in function_dict.items(): | ||
| self.funciton_map[name] = Function(function) | ||
| setattr(self, name, self.funciton_map[name].__call__) |
There was a problem hiding this comment.
Suggested change
| setattr(self, name, self.funciton_map[name].__call__) | |
| setattr(self, name, self.funciton_map[name]) |
是不是不需要设置__call__，直接setattr对应的Function即可？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[JitLayer]Pybind JitLayer VarBase Function and add python UT