[Phi]Change Copy from Kernel to basic component utils #43622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
previously approved these changes
Jun 21, 2022
| auto kernel = phi::KernelFactory::Instance().SelectKernelOrThrowError( | ||
| "copy", kernel_key); | ||
| VLOG(6) << "copy API kernel: " << kernel; | ||
| VLOG(6) << "start copy. "; |
There was a problem hiding this comment.
log用start copy的话感觉还需要一个finish copy来对应
zyfncg
approved these changes
Jun 24, 2022
sneaxiy
pushed a commit
to sneaxiy/Paddle
that referenced
this pull request
Jun 27, 2022
…3622) * perfect copy * deal with conflict * deal with conflict * fix compile bugs * fix unittest bugs * change code format * deal with conflict * modify code by review * fix ce bugs * fix ce bugs * add lo * perfect code format * deal with conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
当前的CopyKernel存在一些局限性：
1，推理需要kernel里不使用单例，而当前的CopyKernel里存在使用单例的情况且在Kernel里不太好去除。
2，Kernel的形式只能传递一个dev_context参数，而实际的Copy功能有传递俩个dev_context参数的需求。
3，根据datatype,layout,backend等不同可以来区分不同kernel，而copy在算子库中应该是一个工具类的存在，datatype，backend等的不同得出不同的copy是不太合理的。
该PR主要功能将Copy由Kernel变为基础组件工具：
1，去掉原来的copy_kernel（包括文件，kernel注册），取而代之得是tensor_utils.h中的Copy工具函数
2，将所有使用copy_kernel的地方修改为使用tensor_utils.h下的Copy函数。
后续TODO:
1，优化Copy功能实现，拓展俩个dev_context实现接口。
2，去除掉copy里边的单例使用。