Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2Stat]Fix losting pre/post hook from outermost layer while jit.save #42273

Merged
merged 3 commits into from
Apr 29, 2022

Conversation

Aurelius84
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

[Dy2Stat]Fix losting pre/post hook from outermost layer while jit.save

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Aurelius84 Aurelius84 requested a review from 0x45f April 26, 2022 07:37
@rainyfly
Copy link
Contributor

当放入input_spec参数时,程序会报错

@rainyfly
Copy link
Contributor

Works, LGTM

Copy link
Contributor

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scope = core.Scope()
extra_var_info = dict()
if isinstance(layer, Layer):
functions = dir(inner_layer)
if inner_layer._forward_pre_hooks or inner_layer._forward_post_hooks:
with_hook = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面可以在讨论下with_hook参数的是否必要

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@Aurelius84 Aurelius84 merged commit 27cf7af into PaddlePaddle:develop Apr 29, 2022
Aurelius84 added a commit to Aurelius84/Paddle that referenced this pull request Apr 29, 2022
PaddlePaddle#42273)

* [Dy2Stat]Fix losting pre/post hook from outermost layer while jit.save

* fix kwargs

* fix unittest
phlrain pushed a commit that referenced this pull request Apr 30, 2022
#42273) (#42388)

* [Dy2Stat]Fix losting pre/post hook from outermost layer while jit.save

* fix kwargs

* fix unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants