Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick] Organize the API of custom operators #41882

Merged
merged 6 commits into from
Apr 18, 2022
Merged

[Cherry-pick] Organize the API of custom operators #41882

merged 6 commits into from
Apr 18, 2022

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Apr 17, 2022 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Describe

[Cherry-pick] Organize the API of custom operators

  1. 移除Tensor API接口中对废弃PlaceType类型的使用，对一些Tensor的不合规接口添加deprecated提示，详细背景见PR介绍 [Phi&CustomOp] Remove deprecated enum PlaceType for custom op & add warning #41647
  2. 移除框架中对deprecated接口Tensor::is_initialized()的使用，替换为Tensor:initialized()，与DenseTensor保持上下一致 Remove all Tensor.is_initialized using in framework #41766
  3. 移除废弃接口Tensor::inner_place()及框架中对此接口的使用，替换为Tensor::place()接口，内外保持一致 Remove Tensor.inner_place using in framework #41768
  4. 减少deprecated接口warning的次数，仅第一次打印warning，避免刷屏 [CustomOp] Polish tensor depreacted method warning #41807
  5. 修复PlaceType移除导致的历史自定义算子兼容问题，恢复PlaceType枚举类型确保兼容 [CustomOp] Fix PlaceType related compat error #41826

@chenwhql
[Phi&CustomOp] Remove deprecated enum PlaceType for custom op & add w…
880f393 
…arning (PaddlePaddle#41647)

* remove old custom op placetype

* replace dist  placetype using

* add with gpu macro

* fix mutable_data error

* fix set value error

* add comment
@chenwhql
remove all is initialized using (PaddlePaddle#41766)
e13ceee
@chenwhql
remove inner_place using (PaddlePaddle#41768)
26eb567
@chenwhql
polish tensor depreacted method warning (PaddlePaddle#41807)
83b3209
@chenwhql
[CustomOp] Fix PlaceType related compat error (PaddlePaddle#41826)
d7c74e9 
* fix place type related compat error

* fix test failed

* remove dll decl

* revert place type change

* add dll decl
@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XiaoguangHu01
XiaoguangHu01 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain merged commit 897911f into PaddlePaddle:release/2.3 Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@zyfncg zyfncg zyfncg approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenwhql @luotao1 @zyfncg @XiaoguangHu01 @phlrain