-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CustomOp] Add context pool unittests #41085
Merged
chenwhql
merged 9 commits into
PaddlePaddle:develop
from
chenwhql:add_context_pool_in_custom_op
Apr 12, 2022
Merged
[CustomOp] Add context pool unittests #41085
chenwhql
merged 9 commits into
PaddlePaddle:develop
from
chenwhql:add_context_pool_in_custom_op
Apr 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry to inform you that d622be8's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
… add_context_pool_in_custom_op
XieYunshen
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
设置单测时间
Aurelius84
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Apr 13, 2022
* add context pool unittests * fix timeout * polish details * change option pos * add dll decl for wndows * fix pre-commit error * move dll_decl and export DeviceContext * replace lost dll_decl.h
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Apr 14, 2022
* add context pool unittests * fix timeout * polish details * change option pos * add dll decl for wndows * fix pre-commit error * move dll_decl and export DeviceContext * replace lost dll_decl.h
phlrain
pushed a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
[CustomOp] Add context pool unittests
部分高阶用户需要在自定义算子中获取内部DeviceContext,使用内部Context的一些handle,确保自定义算子存储管理与框架一致,避免自定义算子内频繁发生内存申请释放操作从而影响性能,因此本PR将DeviceContextPool作为experimental API暴露到自定义算子体系中
相关前序PR:#40635
不过2.3版本开始,更推荐用对外包装好的C++运算API组合实现算子,写法更简单,同时也不会有以上问题