Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move meshgrid to phi #40994

Merged
merged 35 commits into from
Mar 28, 2022
Merged

Conversation

phlrain
Copy link
Collaborator

@phlrain phlrain commented Mar 27, 2022

PR types

Breaking changes

PR changes

OPs

Describe

move meshgrid to phi

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SelectedRows的kernel还是需要拆分到selected rows子目录的,后续麻烦追加PR拆分

@phlrain
Copy link
Collaborator Author

phlrain commented Mar 28, 2022

SelectedRows的kernel还是需要拆分到selected rows子目录的,后续麻烦追加PR拆分

#40918 这个pr中有拆分的内容,会继续将pr merge

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain merged commit ca87195 into PaddlePaddle:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants