fix lars optitmizer bug #40892
Merged
fix lars optitmizer bug #40892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR's description meets the template requirements! |
|
你的PR提交成功，感谢你对开源项目的贡献! |
TCChenlong
previously approved these changes
Mar 25, 2022
firestonelib
dismissed stale reviews from TCChenlong, XiaoguangHu01, jzhang533, wangxicoding, and JamesLim-sy
via
807adc3
fuyinno4
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Fix lars optimizer lars_weight_decay=0 bug:
When lars_weight_decay=0, we got local_learning_rate = learning_rate * lars_coeff * ||param|| / ||gradient||, but the formula in lars_momentum_op.cu when lars_weight_decay =0 equals to local_learning_rate = learning_rate.