Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cinn graph may hasn't input problem #40814

Merged

Conversation

thisjiang
Copy link
Contributor

@thisjiang thisjiang commented Mar 22, 2022

PR types

Bug fixes

PR changes

APIs

Describe

The cinn-graph may hasn't input for CINN now support fill_constant, and it's all inputs may generated by fill_constant instead of by fetch.

So we remove the input check in InferShape, and rewrite the GetExpectedKernelType for the base function may error when the op hasn't input.

The new GetExpectedKernelType infer the kernel type from output, it's tensor has been initialized before (otherwise the default type is DataType::UNDEFINED).

Copy link
Contributor

@CtfGo CtfGo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisjiang thisjiang merged commit 17b8335 into PaddlePaddle:develop Mar 23, 2022
@thisjiang thisjiang deleted the fix_cinn_subgraph_no_input branch March 23, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants