Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pybind index error #40538

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Remove pybind index error #40538

merged 3 commits into from
Mar 15, 2022

Conversation

zyfncg
Copy link
Contributor

@zyfncg zyfncg commented Mar 14, 2022

PR types

Others

PR changes

Others

Describe

Because pybind::index_error may cause some unexpected behavior on Windows system,
this PR replace pybind::index_error with PADDLE_ENFORCE or PADDLE_THROW.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zyfncg zyfncg mentioned this pull request Mar 14, 2022
Closed
@zyfncg zyfncg merged commit 47d764a into PaddlePaddle:develop Mar 15, 2022
@zyfncg zyfncg deleted the remove_pybind_index_error branch March 15, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyfncg @zhwesky2010