Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Phi]move reduce_min/any/all kernel #40374

Merged
merged 9 commits into from
Mar 15, 2022
Merged

[Phi]move reduce_min/any/all kernel #40374

merged 9 commits into from
Mar 15, 2022

Conversation

MingMingShangTian
Copy link
Contributor

@MingMingShangTian MingMingShangTian commented Mar 9, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Move reduce_min, reduce_any, reduce_all into phi.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 9, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@MingMingShangTian MingMingShangTian changed the title add reduce_min kernel [Phi]move reduce_min/any/all kernel Mar 14, 2022
chenwhql
chenwhql reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

每个kernel实现都很短，是不是合并成reduce_kernel比较好

chenwhql
chenwhql approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像reduce max已经合入了，后面建议整合一下

@MingMingShangTian
Copy link
Contributor Author

reduce_kernel

后续合并一下

XiaoguangHu01
XiaoguangHu01 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MingMingShangTian MingMingShangTian merged commit c46e661 into PaddlePaddle:develop Mar 15, 2022
@MingMingShangTian MingMingShangTian deleted the other_reduce_ops branch March 15, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyfncg zyfncg zyfncg approved these changes

@chenwhql chenwhql chenwhql approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MingMingShangTian @zyfncg @chenwhql @YuanRisheng @XiaoguangHu01