Move Pool OPs to phi #40208
Merged
Move Pool OPs to phi #40208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Xreki
reviewed
Mar 8, 2022
| adaptive) { // for adaptive_avg_pool2d && output_size == 1 | ||
| #if defined(__HIPCC__) || defined(__NVCC__) | ||
| auto stream = ctx.stream(); | ||
| funcs::TensorReduceImpl<T, T, kps::AddFunctor, kps::DivideFunctor<T>>( |
There was a problem hiding this comment.
该函数名已经修改为func::ReduceKernel，并且不再需要传递最后的stream参数，辛苦修改一下。
相关的几个API添加的Benchmark脚本都已经合入了的 |
From00
requested review from
YuanRisheng,
chenwhql,
zyfncg and
MingMingShangTian
zyfncg
previously approved these changes
Mar 11, 2022
Comment on lines
+118
to
+128
| void MaxPoolWithIndexGradInferMeta(const MetaTensor& x, | ||
| const MetaTensor& mask, | ||
| const MetaTensor& dout, | ||
| const std::vector<int>& kernel_size, | ||
| const std::vector<int>& strides, | ||
| const std::vector<int>& paddings, | ||
| bool global_pooling, | ||
| bool adaptive, | ||
| MetaTensor* dx) { | ||
| dx->share_meta(x); | ||
| } |
There was a problem hiding this comment.
[TODO] 这里实际上仅需要X的一个输入，但为了匹配kernel参数放入了大量无用参数，后面尝试下通过yaml配置避免这种写法
Comment on lines
15
to
16
| #include "paddle/phi/kernels/impl/pool_grad_kernel_impl.h" | ||
| #include "paddle/phi/kernels/pool_grad_kernel.h" |
Comment on lines
15
to
16
| #include "paddle/phi/kernels/impl/pool_kernel_impl.h" | ||
| #include "paddle/phi/kernels/pool_kernel.h" |
|
|
||
| PD_REGISTER_KERNEL( | ||
| pool2d_grad, CPU, ALL_LAYOUT, phi::Pool2dGradKernel, float, double) {} | ||
| PD_REGISTER_KERNEL(pool2d_grad_grad, |
There was a problem hiding this comment.
pool2d_grad_grad 可以后面换成 pool2d_double_grad
zyfncg
previously approved these changes
Mar 11, 2022
YuanRisheng
previously approved these changes
Mar 11, 2022
zyfncg
approved these changes
Mar 14, 2022
YuanRisheng
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe