Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phi] move InferShape for truncated_gaussian_random and gaussian_random #40191

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

windstamp
Copy link
Contributor

PR types

Function optimization

PR changes

OPs

Describe

[Phi] move InferShape for truncated_gaussian_random and gaussian_random

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 5, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zyfncg
zyfncg previously approved these changes Mar 7, 2022
@@ -21,6 +21,9 @@
#include "paddle/phi/core/dense_tensor.h"
#include "paddle/phi/core/device_context.h"

#include "paddle/phi/infermeta/nullary.h"
#include "paddle/phi/kernels/empty_kernel.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥include了empty_kernel.h?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉了,thanks。

DataType dtype,
MetaTensor* out);

void GaussianRandomInferMeta(const ScalarArray& shape,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不是vector吗,我看下边的kernel全部替换成了vector

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truncated_gaussian_random 是 std::vector,gaussian_random 还是 ScalarArray。

@windstamp windstamp merged commit 81d4142 into PaddlePaddle:develop Mar 8, 2022
@windstamp windstamp deleted the phi_infersape branch March 8, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants