[Phi]Move Relu/Cos/Sin/Tan/Acos/Asin/Atan/Sinh/Cosh/Asinh/Acosh/Atanh kernels in Activation to Phi #40175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Mar 7, 2022
| #include "paddle/phi/common/bfloat16.h" | ||
| #include "paddle/phi/common/float16.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/activation_kernel.h" |
| #include "paddle/phi/common/bfloat16.h" | ||
| #include "paddle/phi/common/float16.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/activation_kernel.h" |
| } | ||
|
|
||
| template <typename T, typename Context, typename Functor> | ||
| void ActivationGradImpl(const Context& dev_ctx, |
| #define ToString(x) #x | ||
|
|
||
| template <typename T, typename Context, typename Functor> | ||
| void ActivationImpl(const Context& dev_ctx, |
There was a problem hiding this comment.
这里的impl是不是只有cpu kernel用了？需要impl.h吗
There was a problem hiding this comment.
不是，这个存在cuda kernel使用的情况
zyfncg
reviewed
Mar 7, 2022
|
|
||
| template <typename T> | ||
| using ReluGradGradFunctor = phi::funcs::ReluGradGradFunctor<T>; | ||
| template <typename T> | ||
| struct ReluCUDAFunctor : public BaseActivationFunctor<T> { |
| #include "paddle/phi/common/bfloat16.h" | ||
| #include "paddle/phi/common/float16.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/activation_kernel.h" |
| #include "paddle/phi/core/enforce.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/funcs/eigen/common.h" | ||
|
|
There was a problem hiding this comment.
这些activation_functor放到funcs下有什么考虑吗？
There was a problem hiding this comment.
非activation的kernel也会调用
zyfncg
approved these changes
Mar 7, 2022
MingMingShangTian
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
将三角函数系列及Relu的前反向Kernel移动到Phi下