【Phi】Migrate bitwise_and/bitwise_or/bitwise_xor/bitwise_not op into phi #40031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwesky2010
changed the title
|
Thanks for your contribution! |
zyfncg
previously approved these changes
Mar 3, 2022
|
|
||
| #include "paddle/phi/backends/gpu/gpu_context.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/bitwise_kernel.h" |
YuanRisheng
reviewed
Mar 3, 2022
| const DenseTensor& y, \ | ||
| DenseTensor* out) { \ | ||
| funcs::Bitwise##op_type##Functor<T> func; \ | ||
| ElementwiseCompute<funcs::Bitwise##op_type##Functor<T>, T, T>( \ |
There was a problem hiding this comment.
ci是最新代码跑的结果吗，昨天我把这个函数挪到了funcs下了，按理说编译应该通不过
Comment on lines
21
to
22
| #include "paddle/phi/kernels/funcs/elementwise_base.h" | ||
| #include "paddle/phi/kernels/gpu/elementwise.h" |
There was a problem hiding this comment.
应用一个头文件即可：funcs下的broadcast_function.h
MingMingShangTian
previously approved these changes
Mar 3, 2022
zhwesky2010
dismissed stale reviews from MingMingShangTian and zyfncg
via
242687a
zyfncg
approved these changes
Mar 4, 2022
YuanRisheng
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
OPs
Describe
Migrate bitwise_and/or/xor/not op into phi.