[phi] move is_empty to phi #39919
Merged
[phi] move is_empty to phi #39919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
reviewed
Feb 28, 2022
paddle/fluid/operators/is_empty_op.h
Outdated
| @@ -1,11 +1,8 @@ | |||
| /* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved. | |||
|
|
|||
There was a problem hiding this comment.
licence里的这些空行是固定格式，不用删，可参考其他文件
| // Note: is_empty is always executed on CPU and the output data should | ||
| // always be allocated for CPUPlace. We reigister CUDA kernel for this op to | ||
| // avoid the unnecessary data transform. | ||
| out->mutable_data<bool>(phi::CPUPlace())[0] = phi::product(x.dims()) == 0; |
There was a problem hiding this comment.
这里可以使用dev_ctx.template HostAlloc<T>()接口替换mutable_data
There was a problem hiding this comment.
看注释，这里应该是改为： phi::CPUPlace().HostAlloc() 吧
There was a problem hiding this comment.
具体应该怎么改呢，改成下面这样吗
out->mutable_data(phi::CPUPlace().HostAlloc())[0] = phi::product(x.dims()) == 0;
YuanRisheng
previously approved these changes
Mar 1, 2022
| double, | ||
| int, | ||
| int64_t) {} | ||
| #endif |
chenwhql
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
move is_empty to phi