Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] fix Managed Memory Alloc on HIP, test=develop #39896

Merged
merged 2 commits into from
Feb 25, 2022
Merged

[ROCm] fix Managed Memory Alloc on HIP, test=develop #39896

merged 2 commits into from
Feb 25, 2022

Conversation

qili93
Copy link
Contributor

@qili93 qili93 commented Feb 24, 2022 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

Fix cuda_managed_memory_test failure on DCU.

  1. DCU NOT support managed Memory now:
    image

  2. Fix cuda_managed_memory_test to handle Paddle enforce not met instead of badalloc

Related PR #39075

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@qili93 qili93 requested a review from From00 February 24, 2022 08:40
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

From00
From00 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 requested a review from zhiqiu February 25, 2022 02:51
zhiqiu
zhiqiu approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 37cb6f3 into PaddlePaddle:develop Feb 25, 2022
@qili93 qili93 deleted the fix_managed_memory_dcu branch February 25, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@From00 From00 From00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qili93 @CLAassistant @zhiqiu @From00