[phi] move bce_loss to phi #39868
Merged
[phi] move bce_loss to phi #39868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
approved these changes
Feb 24, 2022
| label_dims)); | ||
| } | ||
|
|
||
| out->set_dims(input_dims); |
There was a problem hiding this comment.
这里InferMeta范围要比原先的InferShape广，InferMeta推断的是tensor中的meta信息，包括推断dtype，所以在迁移时顺便加一下set_dtype()更好一些，后面可以再加，指南里我也补充了一下
zyfncg
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
move bce_loss to phi
CUDA Kernel里面只能使用PADDLE_ENFORCE进行错误检查，且不能使用CPU端定义的error类型
参考：#32265