Add StringTensor #39830
Merged
Add StringTensor #39830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Conflicts: cmake/phi.cmake paddle/phi/CMakeLists.txt paddle/phi/api/CMakeLists.txt paddle/phi/api/lib/CMakeLists.txt paddle/phi/api/lib/utils/CMakeLists.txt paddle/phi/common/data_type.h paddle/phi/core/kernel_utils.h paddle/phi/tests/api/CMakeLists.txt paddle/phi/tests/kernels/CMakeLists.txt
joey12300
force-pushed
the
add_string_tensor
branch
from
958b18b
to
05043fc
Compare
joey12300
force-pushed
the
add_string_tensor
branch
from
05043fc
to
a9928ca
Compare
2. Add StringTensor debug info 3. Rename case_convert_kernel to strings_lower_upper 4. Remove serialize derialize strings kernel
chenwhql
previously approved these changes
Mar 23, 2022
| @@ -0,0 +1,112 @@ | |||
| /* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
joey12300
force-pushed
the
add_string_tensor
branch
from
6856986
to
bef8cbe
Compare
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Mar 28, 2022
This reverts commit 0695e1a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
该PR仅修改C++层的代码，暂时不涉及Python API的修改
TODO：
Optimize the build size
背景
该PR Coverage CI生成的build目录的大小为140GB，增量为4GB，超过了该CI的阈值3GB，需要优化build目录的生成大小。
优化方法
经过分析发现，在生成strings_api.cc的时候，引入了不必要的头文件
paddle/phi/kernels/declarations.h,该头文件会把Paddle所有kernel的声明引入，并在链接时将其实现链接，形成一个超大的可执行文件。通过去除该头文件，在本地编译时，单测可执行文件test_strings_empty_api与test_strings_lower_upper_api的大小从241MB下降到10MB，与其他单测可执行文件大小相仿。而Coverage CI生成的build目录大小也从140GB下降到137GB，增量从4GB下降到1GB。