[Phi] Migrate unfold_op into phi #39778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Aurelius84
requested review from
chenwhql,
YuanRisheng and
MingMingShangTian
chenwhql
reviewed
Feb 22, 2022
| PADDLE_ENFORCE_GT( | ||
| output_height, | ||
| 0, | ||
| phi::errors::InvalidArgument( |
There was a problem hiding this comment.
一个讨论，话说其实正在phi里面，我们不用加这个phi的前缀，errors还有make_ddim，后面是不是统一把这些去掉让代码更简洁一些
| namespace funcs { | ||
|
|
||
| //////// CalcOutputSize Functor /////// | ||
| inline int CalcOutputSize(int input_size, |
There was a problem hiding this comment.
common_shape.h的函数是多个Op公有的？这个CalcOutputSize函数是unfold单独用到的。另外后续common_shape.h 后续如果包含了超多函数，这里include会不会代码膨胀？
Aurelius84
commented
Feb 22, 2022
| namespace funcs { | ||
|
|
||
| //////// CalcOutputSize Functor /////// | ||
| inline int CalcOutputSize(int input_size, |
There was a problem hiding this comment.
common_shape.h的函数是多个Op公有的？这个CalcOutputSize函数是unfold单独用到的。另外后续common_shape.h 后续如果包含了超多函数，这里include会不会代码膨胀？
zyfncg
approved these changes
Feb 22, 2022
| namespace phi { | ||
|
|
||
| template <typename T, typename Context> | ||
| void UnfoldGradKernel(const Context& ctx, |
There was a problem hiding this comment.
目前kernel的Context模板参数变量名建议使用dev_ctx
YuanRisheng
reviewed
Feb 22, 2022
| namespace funcs { | ||
|
|
||
| //////// CalcOutputSize Functor /////// | ||
| inline int CalcOutputSize(int input_size, |
There was a problem hiding this comment.
如果这个函数只有unfold这个op使用的话，可以放到impl下，funcs下一般放的是多op使用的函数
There was a problem hiding this comment.
我在 #39796 这里会移动到impl目录里
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
[Phi] Migrate unfold_op into phi