Modified RandomKernel with Kernel Primitive API #39666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
AnnaTrainingG
force-pushed
the
IndexRandom
branch
from
b9b5728
to
20806bf
Compare
Liu-xiandong
approved these changes
Feb 21, 2022
zkh2016
approved these changes
Feb 21, 2022
AnnaTrainingG
changed the title
|
PR描述需要说明下问题的背景，PR的改动点比如你这个PR里新增、删除、修改了什么 |
| @@ -714,5 +714,14 @@ __device__ __forceinline__ void ReadDataBc( | |||
| } | |||
| } | |||
|
|
|||
| template <typename T, int NX, int NY, int BlockSize> | |||
There was a problem hiding this comment.
这个接口是否需要加一下说明，使用场景？其他的接口都有解释
There was a problem hiding this comment.
会的，后面会统一加注释和说明文档
| @@ -21,7 +21,7 @@ | |||
| import paddle.fluid.core as core | |||
| from paddle.fluid.op import Operator | |||
| from paddle.fluid.executor import Executor | |||
| from op_test import OpTest | |||
| from paddle.fluid.tests.unittests.op_test import OpTest | |||
There was a problem hiding this comment.
这个不该另外一个文件引用的时候会挂掉（不同目录下的）
| int grid = config.block_per_grid.x; | ||
| int block = config.thread_per_block.x; | ||
| auto stream = dev_ctx.stream(); | ||
| #endif |
There was a problem hiding this comment.
XPU的线程配置是否合并到GetGpuLaunchConfig1D里面更好？这里线程配置就不用写分支了。包括stream的获取。可以考虑优化下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Modifide RandomKernel with Kernel Primitive API
背景：为提升KP 算子覆盖率，为XPU 40+ 模型提供算子支持，此处将gaussian/uniform_random中的Kernel实现替换为KP Kernel实现。
PR改动：
正确性说明： uniform_random_inplace_op/ uniform_random_op/ gaussian_random 的单测均已在develop分支中,py3可以测试到。
3.test_uniform_random_op