Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bf16] pten matmul cuda kernel support bf16 #39485

Merged
merged 10 commits into from
Feb 16, 2022

Conversation

zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Feb 11, 2022

PR types

New features

PR changes

OPs

Describe

[bf16] pten matmul and matmul_grad cuda kernel support bf16

image

image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -94,6 +94,7 @@ PT_REGISTER_KERNEL(empty_like,
int64_t,
bool,
paddle::platform::float16,
paddle::platform::bfloat16,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里类型建议都使用pten::dtype::xxx

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark

@zhiqiu zhiqiu merged commit d5a0d31 into PaddlePaddle:develop Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants