Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Embedding layer support more int ids type #39381

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Make Embedding layer support more int ids type #39381

merged 4 commits into from
Feb 8, 2022

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Feb 8, 2022

PR types

Function optimization

PR changes

OPs

Describe

Make Embedding layer supports more int Ids type, such as int16, int8, etc.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Feb 8, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

chenwhql
chenwhql approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 60f1461 into PaddlePaddle:develop Feb 8, 2022
@sneaxiy sneaxiy deleted the add_more_int_support_for_embedding branch February 8, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenwhql chenwhql chenwhql approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sneaxiy @chenwhql