[PTEN] Update gpu_context. #39359
Merged
[PTEN] Update gpu_context. #39359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
jiweibo
force-pushed
the
gpu_context_2
branch
from
9010c34
to
3786705
Compare
chenwhql
reviewed
Feb 8, 2022
paddle/pten/kernels/CMakeLists.txt
Outdated
| @@ -10,7 +10,7 @@ add_subdirectory(funcs) | |||
| set_property(GLOBAL PROPERTY PTEN_KERNELS "") | |||
|
|
|||
| set(COMMON_KERNEL_DEPS dense_tensor sparse_coo_tensor sparse_csr_tensor kernel_context kernel_factory arg_map_context convert_utils lod_utils) | |||
| set(COMMON_KERNEL_DEPS ${COMMON_KERNEL_DEPS} eigen_function blas math_function) | |||
| set(COMMON_KERNEL_DEPS ${COMMON_KERNEL_DEPS} eigen_function blas math_function im2col vol2col) | |||
There was a problem hiding this comment.
这两个依赖应该是有极少数kernel需要吧，建议添加具体kernel时，再增加依赖，通过kernel_library(***_kernel DEPS ...)，先不添加为公共依赖
phlrain
approved these changes
Feb 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
update gpu_context cudnn_workspace_handle interface.
patch for gpu_context #39305
TODO:
cudnn_workspace_handle接口，暂时为了保证向后兼容，接口返回类型未修改，未来验证性能正确性问题后，改为返回指针。