[Move selected_rows PR #3] Change the relationship of [include/Cmake]. #39128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
veyron95
force-pushed
the
fluid_move_selected_rows_to_pten_3
branch
from
e2058b3 to
81f6a7e
Compare
…ip, use pten::SelectedRows in Fluid
veyron95
force-pushed
the
fluid_move_selected_rows_to_pten_3
branch
from
b0c13f3 to
8c51888
Compare
jim19930609
previously approved these changes
Jan 24, 2022
chenwhql
previously approved these changes
Jan 24, 2022
veyron95
dismissed stale reviews from chenwhql, XiaoguangHu01, ZzSean, jim19930609, and XieYunshen
via
4511b17
jim19930609
previously approved these changes
Jan 24, 2022
chenwhql
previously approved these changes
Jan 24, 2022
XieYunshen
previously approved these changes
Jan 24, 2022
veyron95
dismissed stale reviews from XieYunshen, chenwhql, jim19930609, XiaoguangHu01, and ZzSean
via
3942e0f
XieYunshen
approved these changes
Jan 24, 2022
chenwhql
approved these changes
Jan 25, 2022
YuanRisheng
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
A series of jobs where selected_rows moves from Fluid to Pten.
There are 5 PR to complete the migration work in expected.
PR 1: Renamed selected_rows.* to selected_rows_utils.* PR39037
PR 2: Added selected_rows.* and rw_lock.h to Pten PR39087
This is PR 3: Change the relationship of [include/Cmake.
follow-up work：
PR 4: Selected_Rows inherits from TensorBase.
PR 5: VisitDataType --> pten::DataType