[PTEN] Add pten::Place data structure. #38844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Shixiaowei02
previously approved these changes
Jan 10, 2022
zhiqiu
reviewed
Jan 10, 2022
paddle/pten/core/place.cc
Outdated
| } | ||
|
|
||
| std::string Place::DebugString() const { | ||
| std::string str{"Place:{type = "}; |
There was a problem hiding this comment.
Better format as "Place(cpu), Place(gpu:0), etc" , to be consistent with paddle.set_device
There was a problem hiding this comment.
Now the format is "Place(cpu), Place(gpu:0), Place(gpu pinned)". Thanks
chenwhql
reviewed
Jan 10, 2022
paddle/pten/core/place.cc
Outdated
| @@ -0,0 +1,60 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
paddle/pten/core/place.h
Outdated
| namespace pten { | ||
|
|
||
| enum class AllocationType : int8_t { | ||
| kUndef = 0, |
There was a problem hiding this comment.
之前和晓伟讨论过，这里需要和其他基础数据结构data type, layout命名风格保持统一，采用全大写的命名风格，因为这个是对外API，对外用户可能并不清楚k前缀的含义
paddle/pten/core/place.h
Outdated
| @@ -0,0 +1,112 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
paddle/pten/core/place.h
Outdated
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
为什么place不需要在common中，API层面使用什么place？
paddle/pten/tests/core/test_place.cc
Outdated
| @@ -0,0 +1,51 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
XieYunshen
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Add pten::Place data structure.
Place consists of enum and device_id.