Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Add input data type checking in BF16 placement pass #38702

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Jan 4, 2022

PR types

Bug fixes

PR changes

Others

Describe

This PR adds checking input data type in cpu_bfloat16_placement_pass. The bfloat16 system supports conversion only from float32 to bfloat16, when the input data type is different operator shouldn't use the bfloat16 data type. This PR resolves the issue #38687.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jan 4, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@baoachun baoachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-intel
Copy link
Contributor

Hi @Aganlengzi, Baoachun has approved this PR. Please help merge. Thank you a lot !

@Aganlengzi Aganlengzi merged commit 60c51de into PaddlePaddle:develop Jan 5, 2022
@lidanqing-intel lidanqing-intel changed the title Add input data type checking in BF16 placement pass [Bug fix] Add input data type checking in BF16 placement pass Jan 27, 2022
@wozna wozna deleted the issue_38687 branch February 24, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants