Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi carriers #38650

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Dec 31, 2021

PR types

Others

PR changes

Others

Describe

修改多carriers接口,根据program对应不同的carrier
截屏2021-12-31 下午6 59 55

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit 2273471 into PaddlePaddle:develop Jan 4, 2022
}
carrier_id_to_interceptor_ids.emplace(0, interceptor_ids);
runtime_graph_->SetInterceptorIdToRank(task_id_to_rank);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对于不同的program,我们共用runtime graph么?是不是这个改成个map比较好,一个carrier id对应一个runtime graph这样?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个确实后面要改的

class GlobalVal final {
public:
static T Get() { return *GetPtr(); }
static T Set(T val) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数为啥有返回值

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants