Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mul BF16/FP32 FWD/BWD oneDNN kernel #38552

Merged
merged 13 commits into from
Jan 13, 2022
Merged

Added mul BF16/FP32 FWD/BWD oneDNN kernel #38552

merged 13 commits into from
Jan 13, 2022

Conversation

jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Dec 28, 2021 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

Added mul BF16/FP32 FWD/BWD oneDNN kernel for enabling bf16 training

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

pawelpiotrowicz
pawelpiotrowicz previously approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@pawelpiotrowicz pawelpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase jakpiase requested a review from jczaja January 11, 2022 13:19
jczaja
jczaja approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase
Copy link
Contributor Author

Hi @Aganlengzi, it is an op needed for BF16 training, could you please review and merge(CI-APPROVAL is failing due to deleting mul_mkldnn_op.cc from unity_build. I have removed it because there were some build errors caused by the presence of mul_mkldnn_op.cc in that file, and it deleting it was the easiest way to fix that.

@Aganlengzi
Copy link
Contributor

Hi @Aganlengzi, it is an op needed for BF16 training, could you please review and merge(CI-APPROVAL is failing due to deleting mul_mkldnn_op.cc from unity_build. I have removed it because there were some build errors caused by the presence of mul_mkldnn_op.cc in that file, and it deleting it was the easiest way to fix that.

@Avin0323 hi, Plz help check deleting mul_mkldnn_op.cc from unity_build_rule.cmake.

Avin0323
Avin0323 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for unity_build_rule.cmake

Aganlengzi
Aganlengzi approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aganlengzi Aganlengzi merged commit fc6eed5 into PaddlePaddle:develop Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aganlengzi Aganlengzi Aganlengzi approved these changes

@jczaja jczaja jczaja approved these changes

@Avin0323 Avin0323 Avin0323 approved these changes

@pawelpiotrowicz pawelpiotrowicz pawelpiotrowicz left review comments

Assignees
No one assigned
Labels
BF16 Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakpiase @Aganlengzi @jczaja @Avin0323 @pawelpiotrowicz