Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add float16 type for scatter op. #38136

Merged
merged 7 commits into from
Dec 16, 2021

Conversation

limin2021
Copy link
Contributor

@limin2021 limin2021 commented Dec 14, 2021

PR types

Function optimization

PR changes

OPs

Describe

Add support of float16 type for scatter op.
(1) Add register for float16 in scatter_op.cu
(2) Add unittest for float16 in test_scatter_op.py

Unittest output:

image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

sneaxiy
sneaxiy previously approved these changes Dec 14, 2021
Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Dec 15, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Dec 15, 2021
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @unittest.skipIf

@sneaxiy sneaxiy merged commit 9bac4a7 into PaddlePaddle:develop Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants