[PTen] Refine Kernel Registrar Writing #37977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pten/auto_generate_kernel_declare
|
Thanks for your contribution! |
zyfncg
reviewed
Dec 9, 2021
| * of the kernel, this registration macro will not do automatic template | ||
| * instantiation. | ||
| */ | ||
| #define PT_REGISTER_SINGLE_KERNEL( \ |
There was a problem hiding this comment.
PT_REGISTER_SINGLE_KERNEL是不是没有使用？
There was a problem hiding this comment.
是的，但是我们需要保留这样一个基础接口，这个是使用一个函数指针进行标准注册的情况，在无法使用PT_REGISTER_KERNEL注册的时候，即使重复写很多遍，也要能注册一个kernel
zyfncg
approved these changes
Dec 9, 2021
YuanRisheng
approved these changes
Dec 9, 2021
| @@ -130,12 +130,9 @@ void Cast(const CPUContext& dev_ctx, | |||
|
|
|||
| } // namespace pten | |||
|
|
|||
| // TODO(chenweihang): replace by better impl | |||
| PT_REGISTER_MODULE(ManipulationCPU); | |||
|
|
|||
| // TODO(yuanrisheng): "flatten_contiguous_range" is compatible with old kernel | |||
| // architecture, kernel_name should be "flatten". | |||
MingMingShangTian
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
[PTen] Refine Kernel Registrar Writing
.overload_name机制去除的话，kernel注册写法改回和原fluid注册一致的写法，即直接使用名字，而不是字符串，在编译自动化上更易实现，因此进行了全局修改