Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster implementation of CPU kernel for ROI Align operator #37848

Merged
merged 12 commits into from
Dec 16, 2021

Conversation

tsocha
Copy link
Contributor

@tsocha tsocha commented Dec 3, 2021

PR types

Function optimization

PR changes

OPs

Describe

About ~20% faster ROI Align implementation in faster_rcnn_r50_fpn_1x_coco model(~2-3% faster model overall).

PR have to be polished.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 3, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jczaja jczaja self-requested a review December 12, 2021 17:29
@tsocha tsocha marked this pull request as ready for review December 13, 2021 12:07
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja
Copy link
Contributor

jczaja commented Dec 15, 2021

@pawelpiotrowicz Please take a look at this PR

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja
Copy link
Contributor

jczaja commented Dec 16, 2021

@baoachun , @Aganlengzi Please start your review & merge

Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aganlengzi Aganlengzi merged commit 023ff4f into PaddlePaddle:develop Dec 16, 2021
@tsocha tsocha deleted the faster-roi branch December 16, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants