[Fleet Executor] Add feed, fetch and check correctness #37824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wangxicoding
previously approved these changes
Dec 3, 2021
python/paddle/fluid/executor.py
Outdated
| cached_ctx = self._prepare_fleet_executor( | ||
| program=cached_program, scope=cached_scope) | ||
| self._add_ctx_cache(cache_key, cached_ctx) | ||
| self._feed_data(cached_program, feed, feed_var_name, cached_scope) |
There was a problem hiding this comment.
混合并行中的Pipeline使用了read op，不用feed。后面可以判断一下，如果用了read相关op，应该不用设置feed
FeixLiu
reviewed
Dec 6, 2021
python/paddle/fluid/executor.py
Outdated
| if cached_program is None: | ||
| cached_program = self._add_feed_fetch_ops( | ||
| program=program, | ||
| feed=feed, |
There was a problem hiding this comment.
这儿需要判断一下，如果feed是NoneType的话，需要传一个[]进去，不然这个函数里的enumerate会报错。
FeixLiu
reviewed
Dec 7, 2021
python/paddle/fluid/executor.py
Outdated
| if cached_program is None: | ||
| real_feed = [] if feed is None else feed | ||
| cached_program = self._add_feed_fetch_ops( | ||
| program=program, |
There was a problem hiding this comment.
这儿为啥用的是program，不是section_program呀
LiYuRio
force-pushed
the
dev_add_feed_fetch
branch
from
92058db
to
824d0a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
在program里增加feed，fetch op，修改测试用例做验证；使用pipeline_degree判断执行策略。