Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick 2.2]fix data parallel when VOCAB var in program #37546

Merged
merged 2 commits into from
Nov 25, 2021
Merged

[cherry-pick 2.2]fix data parallel when VOCAB var in program #37546

merged 2 commits into from
Nov 25, 2021

Conversation

Steffy-zxf
Copy link
Contributor

@Steffy-zxf Steffy-zxf commented Nov 25, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

APIs

Describe

fix data parallel when VOCAB var in program

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 25, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Steffy-zxf Steffy-zxf changed the title fix data parallel when VOCAB var in program [Cherry-pick]fix data parallel when VOCAB var in program Nov 25, 2021
@Steffy-zxf Steffy-zxf changed the title [Cherry-pick]fix data parallel when VOCAB var in program [cherry-pick 2.2]fix data parallel when VOCAB var in program Nov 25, 2021
XieYunshen
XieYunshen previously approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(test_faster_tokenizer_op PROPERTIES LABELS "RUN_TYPE=EXCLUSIVE")

wawltor
wawltor previously approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Steffy-zxf Steffy-zxf dismissed stale reviews from wawltor and XieYunshen via 8dac76a November 25, 2021 10:58
@wawltor wawltor changed the title [cherry-pick 2.2]fix data parallel when VOCAB var in program [cherry-pick 2.2]fix data parallel when VOCAB var in program Nov 25, 2021
wawltor
wawltor approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZeyuChen
ZeyuChen approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen merged commit c8429d3 into PaddlePaddle:release/2.2 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen approved these changes

@wawltor wawltor wawltor approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Steffy-zxf @ZeyuChen @wawltor @XieYunshen