Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the error message of scatter op #37429

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Nov 22, 2021

PR types

Others

PR changes

Others

Describe

Enhance the error message of scatter op. Make out of range error more clear.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

ForFishes
ForFishes previously approved these changes Nov 22, 2021
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy changed the title Enhance error message of scatter op Enhance the error message of scatter op Nov 22, 2021
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 11b17c8 into PaddlePaddle:develop Nov 23, 2021
@sneaxiy sneaxiy deleted the enhance_scatter_err_msg branch November 23, 2021 03:45
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
* enhance scatter err msg check

* fix ci error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants